Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linker annotations to some of CoreLib #36532

Merged
merged 7 commits into from
Jun 9, 2020
Merged

Add linker annotations to some of CoreLib #36532

merged 7 commits into from
Jun 9, 2020

Conversation

MichalStrehovsky
Copy link
Member

Some of these are handled as linker intrinsics, so they'll actually keep less than what the annotation declares. The annotation mostly serves to suppress warnings when linker analyzes the body of the method itself.

@ghost
Copy link

ghost commented May 15, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

Cc @vitek-karas @eerhardt

@MichalStrehovsky
Add linker annotations to some of CoreLib
142d270 
Some of these are handled as linker intrinsics, so they'll actually keep less than what the annotation declares. The annotation mostly serves to suppress warnings when linker analyzes the body of the method itself.
@MichalStrehovsky
CR feedback
dd916d6
@MichalStrehovsky
Annotate a couple more things
b188623
@jaredpar jaredpar mentioned this pull request May 21, 2020
Closed
@MichalStrehovsky
Copy link
Member Author 

    profiler\unittest\getappdomainstaticaddress\getappdomainstaticaddress.cmd [FAIL]
      
      Assert failure(PID 5408 [0x00001520], Thread: 1720 [0x06b8]): The 'LastThrownObject' should not be, but is, NULL.
      The runtime may have lost track of the type of an exception in flight.
      Please get a good stack trace, find the caller of Validate, and file a bug against the owner.
      
      To suppress this assert 'set COMPlus_SuppressLostExceptionTypeAssert=1'
      
      CORECLR! CLRLastThrownObjectException::Validate + 0x1B2 (0x00007ffd`1230fcb2)
      CORECLR! `ETW::GCLog::ForceGCForDiagnostics'::`1'::catch$14 + 0xA1 (0x00007ffd`12c06e97)
      CORECLR! CallSettingFrame_LookupContinuationIndex + 0x20 (0x00007ffd`12aefcc0)
      CORECLR! _FrameHandler4::CxxCallCatchBlock + 0x1DE (0x00007ffd`12aedbfe)
      NTDLL! RtlCaptureContext + 0x3C3 (0x00007ffd`44939b23)
      CORECLR! ETW::GCLog::ForceGCForDiagnostics + 0x283 (0x00007ffd`1232aa9f)
      CORECLR! ProfToEEInterfaceImpl::ForceGC + 0x2F2 (0x00007ffd`126f60d2)
      PROFILER! <lambda_a711db0726cd25ae1a2ebca18937f4db>::operator() + 0xA6 (0x00007ffd`113eeeea)
      PROFILER! std::_Invoker_functor::_Call<<lambda_a711db0726cd25ae1a2ebca18937f4db> > + 0x11 (0x00007ffd`113ed881)
      PROFILER! std::invoke<<lambda_a711db0726cd25ae1a2ebca18937f4db> > + 0x11 (0x00007ffd`113ee015)
          File: F:\workspace\_work\1\s\src\coreclr\src\vm\clrex.cpp Line: 2474
          Image: C:\h\w\B593098A\p\CoreRun.exe

I would say this is unrelated.

@janvorli
Copy link
Member

There is already an issue for this test failure, although the failure mode differs:
#37117
I've noticed this test failing in one of the regularly scheduled tests on Saturday already.

@eerhardt eerhardt mentioned this pull request May 29, 2020
Closed
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Jun 2, 2020
@MichalStrehovsky
Rename DynamicallyAccessedMemberTypes.DefaultConstructor
2a47b94 
API review was done over email.

Approved by @stephentoub, Immo's opinion here: dotnet#36532 (comment). There were no objections.
@MichalStrehovsky MichalStrehovsky mentioned this pull request Jun 2, 2020
Merged
eerhardt
eerhardt approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt eerhardt mentioned this pull request Jun 4, 2020
Closed
@eerhardt
Copy link
Member

eerhardt commented Jun 4, 2020

release mono_interpreter Linux arm64 Debug failure is #37430

eerhardt
eerhardt approved these changes Jun 4, 2020 •
edited
Loading
View reviewed changes
@MichalStrehovsky MichalStrehovsky merged commit 29c4895 into dotnet:master Jun 9, 2020
@MichalStrehovsky MichalStrehovsky deleted the linkCoreLib branch June 9, 2020 09:39
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janvorli janvorli janvorli left review comments

@vitek-karas vitek-karas vitek-karas approved these changes

@danmoseley danmoseley danmoseley left review comments

@terrajobst terrajobst terrajobst left review comments

@stephentoub stephentoub stephentoub left review comments

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@MichalStrehovsky @janvorli @eerhardt @stephentoub @terrajobst @danmoseley @vitek-karas @Dotnet-GitSync-Bot